Deprecate DbClientCommonAttributesGetter #15139
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
changed the title
trask
changed the title
This was referenced Oct 26, 2025
laurit
reviewed
Oct 27, 2025
Comment on lines
+37
to
+40
| /** | ||
| * SqlClientAttributesExtractor will try to populate db.operation.name based on {@link | ||
| * #getRawQueryTexts(REQUEST)}, but this can be used to explicitly provide the operation name. | ||
| */ |
There was a problem hiding this comment.
looks like a copy-paste mistake
laurit
reviewed
Oct 27, 2025
Comment on lines
+47
to
+50
| /** | ||
| * SqlClientAttributesExtractor will try to populate db.operation.name based on {@link | ||
| * #getRawQueryTexts(REQUEST)}, but this can be used to explicitly provide the operation name. | ||
| */ |
There was a problem hiding this comment.
looks like a copy-paste mistake
laurit
reviewed
Oct 27, 2025
| @Override | ||
| public void onStart(AttributesBuilder attributes, Context parentContext, REQUEST request) { | ||
| super.onStart(attributes, parentContext, request); | ||
| // Common attributes |
There was a problem hiding this comment.
could consider placing the common part to util class or perhaps even a static package private method in DbClientAttributesExtractor that could also be called from here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Semconv doesn't have this concept.
HttpCommonAttributesGetter makes sense b/c it's common attributes across both client and server.
But in semconv, Sql "extends" Db semantic conventions, and so I think our getter hierarchy should do the same.
In practice, this means that Sql getter now has things like getDbOperationName(), which I think is probably good, though we can default them to
nullin the Sql getter interface to make them not required.Related to #12608